-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Unskip "classic doc table" flaky test #140786
[Discover] Unskip "classic doc table" flaky test #140786
Conversation
802d36b
to
3e4f7aa
Compare
@elasticmachine merge upstream |
@elasticmachine merge upstream |
this is very odd! No idea so far, @dimaanj you extracted those tests, could you have a look, maybe something catches your attention. FYI: @davismcphee, the more eyes and thoughts, the better. How could a test like this start to fail because the Chrome driver was updated? |
dear @jbudz , you mention I'm going to run this a few more times, and if things look stable mark the doc_table classic suite as flaky. It's not ideal but I think it's more important we get the rest of our tests running on latest. I noticed the table loads quite slow and am wondering if we're causing a browser crash or blocking the main thread too long causing a session reset. in Can you recommend a way to debug this? |
@jughosta I've run a 10x flaky test with my state refactoring, which also removes the skipping of this test, it didn't fail once. |
There's a chance it was a chrome performance regression too - the ML team ran into a similar issue that was eventually fixed in a 106 patch release. |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
Yes, it works fine now. Merged main and ran it again with 150x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1480 |
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 kind of flaky ones we like, right? self-fixing ones 😄
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @jughosta |
* [Discover] Unskip flaky test * [Discover] Fix async tests * [Discover] Try again * [Discover] Try again * [Discover] Try again * [Discover] Try again * [Discover] Try to skip a subtest * [Discover] Try to skip a subtest * [Discover] Try to modify the test * [Discover] Add some logging * [Discover] Return the async * [Discover] Wait for ui * [Discover] Suppress tooltips * [Discover] Suppress tooltips * [Discover] Fix api usage * [Discover] Cleanup Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 48e1b5c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
* [Discover] Unskip flaky test * [Discover] Fix async tests * [Discover] Try again * [Discover] Try again * [Discover] Try again * [Discover] Try again * [Discover] Try to skip a subtest * [Discover] Try to skip a subtest * [Discover] Try to modify the test * [Discover] Add some logging * [Discover] Return the async * [Discover] Wait for ui * [Discover] Suppress tooltips * [Discover] Suppress tooltips * [Discover] Fix api usage * [Discover] Cleanup Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 48e1b5c) Co-authored-by: Julia Rechkunova <[email protected]>
Closes #138652
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1212 (before - failed)
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1316
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1352
28th October 150x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1480 (green)
Another 150x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1482 (green)