Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Unskip "classic doc table" flaky test #140786

Merged
merged 26 commits into from
Oct 28, 2022

Conversation

@jughosta jughosta force-pushed the 138652-unskip-discover-classic-test branch from 802d36b to 3e4f7aa Compare September 19, 2022 13:37
@jughosta jughosta self-assigned this Sep 20, 2022
@jughosta
Copy link
Contributor Author

@elasticmachine merge upstream

@jughosta
Copy link
Contributor Author

Caught it locally too:

Screenshot 2022-09-22 at 14 05 24

@jughosta
Copy link
Contributor Author

@elasticmachine merge upstream

@kertal
Copy link
Member

kertal commented Sep 28, 2022

this is very odd! No idea so far, @dimaanj you extracted those tests, could you have a look, maybe something catches your attention. FYI: @davismcphee, the more eyes and thoughts, the better. How could a test like this start to fail because the Chrome driver was updated?

@kertal
Copy link
Member

kertal commented Oct 11, 2022

dear @jbudz , you mention

I'm going to run this a few more times, and if things look stable mark the doc_table classic suite as flaky. It's not ideal but I think it's more important we get the rest of our tests running on latest.

I noticed the table loads quite slow and am wondering if we're causing a browser crash or blocking the main thread too long causing a session reset.

in

#138658 (comment)

Can you recommend a way to debug this?

@kertal
Copy link
Member

kertal commented Oct 27, 2022

@jughosta I've run a 10x flaky test with my state refactoring, which also removes the skipping of this test, it didn't fail once.
#140765
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1469
given how often it failed before, it might be worth rechecking this PR

@jbudz
Copy link
Member

jbudz commented Oct 27, 2022

There's a chance it was a chrome performance regression too - the ML team ran into a similar issue that was eventually fixed in a 106 patch release.

@jughosta
Copy link
Contributor Author

@elasticmachine merge upstream

@jughosta
Copy link
Contributor Author

@elasticmachine merge upstream

@jughosta jughosta added Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 28, 2022
@jughosta
Copy link
Contributor Author

Yes, it works fine now. Merged main and ran it again with 150x https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1480

@jughosta jughosta marked this pull request as ready for review October 28, 2022 10:55
@jughosta jughosta requested a review from a team as a code owner October 28, 2022 10:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 kind of flaky ones we like, right? self-fixing ones 😄

test/functional/apps/discover/classic/_doc_table.ts Outdated Show resolved Hide resolved
test/functional/apps/discover/classic/_doc_table.ts Outdated Show resolved Hide resolved
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@jughosta jughosta merged commit 48e1b5c into elastic:main Oct 28, 2022
@jughosta jughosta deleted the 138652-unskip-discover-classic-test branch October 28, 2022 13:55
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 28, 2022
* [Discover] Unskip flaky test

* [Discover] Fix async tests

* [Discover] Try again

* [Discover] Try again

* [Discover] Try again

* [Discover] Try again

* [Discover] Try to skip a subtest

* [Discover] Try to skip a subtest

* [Discover] Try to modify the test

* [Discover] Add some logging

* [Discover] Return the async

* [Discover] Wait for ui

* [Discover] Suppress tooltips

* [Discover] Suppress tooltips

* [Discover] Fix api usage

* [Discover] Cleanup

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 48e1b5c)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 31, 2022
* [Discover] Unskip flaky test

* [Discover] Fix async tests

* [Discover] Try again

* [Discover] Try again

* [Discover] Try again

* [Discover] Try again

* [Discover] Try to skip a subtest

* [Discover] Try to skip a subtest

* [Discover] Try to modify the test

* [Discover] Add some logging

* [Discover] Return the async

* [Discover] Wait for ui

* [Discover] Suppress tooltips

* [Discover] Suppress tooltips

* [Discover] Fix api usage

* [Discover] Cleanup

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 48e1b5c)

Co-authored-by: Julia Rechkunova <[email protected]>
@mistic mistic added v8.5.1 and removed v8.5.0 labels Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.5.1 v8.6.0
Projects
None yet
7 participants